Dwrite commented on code in PR #4478:
URL: https://github.com/apache/calcite/pull/4478#discussion_r2296391349
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -16518,6 +16518,218 @@ private static void
checkLogicalOrFunc(SqlOperatorFixture f) {
f.checkNull("CAST(NULL AS INTEGER UNSIGNED) ^^ CAST(NULL AS INTEGER
UNSIGNED)");
}
+ /**
+ * Test cases for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7109";>[CALCITE-7109]
+ * Implement SHIFT_LEFT operator </a>.
+ */
+ @Test void testLeftShiftScalarFunc() {
+ final SqlOperatorFixture f = fixture();
+ f.setFor(SqlStdOperatorTable.BIT_LEFT_SHIFT, VmName.EXPAND);
+
+ // === Basic functionality ===
+ f.checkScalar("2 << 2", "8", "INTEGER NOT NULL");
+ f.checkScalar("1 << 10", "1024", "INTEGER NOT NULL");
+ f.checkScalar("0 << 5", "0", "INTEGER NOT NULL");
+
+ // === Type coercion and signed behavior ===
+ f.checkScalar("CAST(2 AS INTEGER) << CAST(3 AS BIGINT)", "16", "INTEGER
NOT NULL");
+ f.checkScalar("-5 << 2", "-20", "INTEGER NOT NULL");
+ f.checkScalar("-5 << 3", "-40", "INTEGER NOT NULL");
+ f.checkScalar("CAST(-5 AS TINYINT) << CAST(2 AS TINYINT)", "-20", "TINYINT
NOT NULL");
+
+ // === Verify return type matches first argument type ===
+ f.checkType("CAST(2 AS TINYINT) << CAST(3 AS TINYINT)", "TINYINT NOT
NULL");
+ f.checkType("CAST(2 AS SMALLINT) << CAST(3 AS SMALLINT)", "SMALLINT NOT
NULL");
+ f.checkType("CAST(2 AS INTEGER) << CAST(3 AS INTEGER)", "INTEGER NOT
NULL");
+ f.checkType("CAST(2 AS BIGINT) << CAST(3 AS BIGINT)", "BIGINT NOT NULL");
+
+ // === BigInt shifts with explicit BIGINT inputs ===
+ f.checkScalar("CAST(1 AS BIGINT) << 62", "4611686018427387904", "BIGINT
NOT NULL"); // 2^62
+ f.checkScalar("CAST(1 AS BIGINT) << 63", "-9223372036854775808", "BIGINT
NOT NULL"); // overflow
+ f.checkScalar("CAST(4611686018427387904 AS BIGINT) << 1",
+ "-9223372036854775808", "BIGINT NOT NULL"); // overflow
+ f.checkScalar("CAST(2305843009213693952 AS BIGINT) << 2",
+ "-9223372036854775808", "BIGINT NOT NULL"); // overflow
+ f.checkScalar("CAST(-4611686018427387904 AS BIGINT) << 1",
+ "-9223372036854775808", "BIGINT NOT NULL");
+ f.checkScalar("CAST(-1 AS BIGINT) << 63",
+ "-9223372036854775808", "BIGINT NOT NULL");
+ f.checkScalar("CAST(9223372036854775807 AS BIGINT) << 0",
+ "9223372036854775807", "BIGINT NOT NULL");
+ f.checkScalar("CAST(1000000000 AS BIGINT) << 35",
+ "-2533749779419103232", "BIGINT NOT NULL");
+ f.checkScalar("CAST(9223372036854775807 AS BIGINT) << 1",
+ "-2", "BIGINT NOT NULL");
+
+ // === Java shift semantics: bits masked to 5/6 bits ===
+ f.checkScalar("CAST(1 AS BIGINT) << 32",
+ "4294967296", "BIGINT NOT NULL");
+ f.checkScalar("CAST(1 AS BIGINT) << 50",
+ "1125899906842624", "BIGINT NOT NULL");
+ f.checkScalar("CAST(1 AS BIGINT) << 100",
+ "68719476736", "BIGINT NOT NULL");
+ f.checkScalar("CAST(100 AS BIGINT) << 50",
+ "112589990684262400", "BIGINT NOT NULL");
+
+ f.checkScalar("CAST(100 AS BIGINT) << 50",
+ "112589990684262400", "BIGINT NOT NULL");
+
+ // Test left shift (<<) with unsigned types
+ // 63 << 2 = 252
+ f.checkScalar("CAST(63 AS TINYINT UNSIGNED) << 2",
+ "252", "TINYINT UNSIGNED NOT NULL");
+
+ // 255 << 8 = 65280
+ f.checkScalar("CAST(255 AS SMALLINT UNSIGNED) << 8",
+ "65280", "SMALLINT UNSIGNED NOT NULL");
+
+ // 65535 << 16 = 4294901760
+ f.checkScalar("CAST(65535 AS INTEGER UNSIGNED) << 16",
+ "4294901760", "INTEGER UNSIGNED NOT NULL");
+
+ // 1 << 31 = 2147483648 — requires long intermediate result
+ f.checkScalar("CAST(1 AS INTEGER UNSIGNED) << 31",
+ "2147483648", "INTEGER UNSIGNED NOT NULL");
+
+ // Shift by negative — logical right shift by 1 = 0
+ f.checkScalar("CAST(1 AS INTEGER UNSIGNED) << -1",
+ "0", "INTEGER UNSIGNED NOT NULL");
+
+
+ // === Negative shift counts ===
+ f.checkScalar("8 << -1", "4", "INTEGER NOT NULL");
+ f.checkScalar("16 << -2", "4", "INTEGER NOT NULL");
+
+ // === Shift by zero and large (but valid) shifts ===
+ f.checkScalar("0 << 32", "0", "INTEGER NOT NULL");
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
