xiedeyantu commented on code in PR #4515: URL: https://github.com/apache/calcite/pull/4515#discussion_r2312519598
########## core/src/main/java/org/apache/calcite/rel/rules/SortJoinTransposeRule.java: ########## @@ -23,18 +23,23 @@ import org.apache.calcite.rel.RelFieldCollation; import org.apache.calcite.rel.RelNode; import org.apache.calcite.rel.core.Join; -import org.apache.calcite.rel.core.JoinInfo; import org.apache.calcite.rel.core.JoinRelType; import org.apache.calcite.rel.core.Sort; import org.apache.calcite.rel.logical.LogicalJoin; import org.apache.calcite.rel.logical.LogicalSort; import org.apache.calcite.rel.metadata.RelMdUtil; import org.apache.calcite.rel.metadata.RelMetadataQuery; +import org.apache.calcite.rex.RexBuilder; import org.apache.calcite.rex.RexDynamicParam; +import org.apache.calcite.rex.RexLiteral; +import org.apache.calcite.rex.RexNode; import org.apache.calcite.tools.RelBuilderFactory; +import org.checkerframework.checker.nullness.qual.Nullable; import org.immutables.value.Value; +import java.math.BigDecimal; + Review Comment: Indeed, I'd love to know what kind of example I need to add. The logic for whether pushdown is possible and how to do it is a bit complex, and the code is fully commented. One or two examples won't cover everything. If you have any good suggestions, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
