rubenada commented on code in PR #4515:
URL: https://github.com/apache/calcite/pull/4515#discussion_r2313116210


##########
core/src/test/resources/sql/planner.iq:
##########
@@ -351,4 +351,64 @@ FROM "scott"."EMP";
 
 !ok
 
+# [CALCITE-4617] Wrong offset when SortJoinTransposeRule pushes a Sort with an 
offset

Review Comment:
   Could we also have some tests of a query where sort/offset/fetch is actually 
pushed inside the join? (and confirm the results match with vs without the rule)
   I think the original PR has a [couple of 
examples](https://github.com/apache/calcite/pull/2417/files#diff-feaf84fbc8f315359bbce262f7d336969cfae0c1ade39e0dd31db197b9bec27d):



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to