mihaibudiu commented on code in PR #4478:
URL: https://github.com/apache/calcite/pull/4478#discussion_r2314574292
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -895,6 +897,17 @@ void populate1() {
defineMethod(TYPEOF, BuiltInMethod.TYPEOF.method, NullPolicy.STRICT);
defineMethod(VARIANTNULL, BuiltInMethod.VARIANTNULL.method,
NullPolicy.STRICT);
+ // Left shift operations: shift bits to the left by specified amount.
+ // Supports integer, unsigned integer, and binary data types.
+ // Shift amount is normalized using modulo arithmetic based on data type
bit width.
+ //
+ // "<<" operator: Infix syntax for bitwise left shift in SQL expressions
(e.g., x << y)
Review Comment:
if you will add a unit test, maybe you can split this comments into 2 parts,
where each function is documented separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
