xiedeyantu commented on PR #4478: URL: https://github.com/apache/calcite/pull/4478#issuecomment-3247654436
I recommend not force-pushing a PR if it's not ready for squashing. I see @mihaibudiu has suggested some changes, but forcing a push would make it harder for him to spot the changes, and he'd have to spend more time reviewing the PR. I encourage you to keep the commits if possible. By the way, your JIRA and coding style are excellent! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
