Dwrite commented on code in PR #4543:
URL: https://github.com/apache/calcite/pull/4543#discussion_r2384121556
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##########
@@ -1280,8 +1280,11 @@ public class SqlStdOperatorTable extends
ReflectiveSqlOperatorTable {
*/
public static final SqlFunction BITAND =
SqlBasicFunction.create("BITAND", SqlKind.BITAND,
- ReturnTypes.LARGEST_INT_OR_FIRST_NON_NULL,
- OperandTypes.INTEGER_INTEGER.or(OperandTypes.BINARY_BINARY));
+ ReturnTypes.LARGEST_INT_BINARY_OR_LEAST_RESTRICTIVE,
Review Comment:
Thanks for the feedback! I agree that we should avoid changing the semantics
of existing public functions.
For this PR I’ll keep the scope limited to introducing the new & operator,
and won’t touch the existing BITAND implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
