julianhyde commented on code in PR #4561: URL: https://github.com/apache/calcite/pull/4561#discussion_r2389624914
########## core/src/main/java/org/apache/calcite/rel/metadata/FunctionalDependencies.java: ########## @@ -0,0 +1,305 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.metadata; + +import com.google.common.collect.ImmutableSet; + +import java.util.ArrayDeque; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.PriorityQueue; +import java.util.Queue; +import java.util.Set; +import java.util.stream.Collectors; + +import static java.util.Objects.requireNonNull; + +/** + * Models a set of functional dependencies and provides methods for closure computation, + * candidate key search, and related reasoning. + */ +public class FunctionalDependencies { Review Comment: Yes, you can use abbreviations, sparingly. One option is to do as you have done, which is to use noun phrases. But the other is to pick a short noun and define it (and each of the related concepts). "An Arrow is ... The functional dependency 'empno functionally determines (sal, deptno)' is represented by the following two arrows ..." This is what mathematicians do. If you do this, you will not need to use abbreviations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
