xiedeyantu commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3351293345

   I have updated the JavaDoc and also changed the class names. I have covered 
most scenarios in the test classes as much as possible. I believe testing is 
still necessary. If @julianhyde  disagrees with having a separate test file, I 
can integrate it into `RelMetadataTest`. 
   Could @julianhyde and @mihaibudiu  please take another look to see if this 
PR can be merged independently? If it is not approved, I can also continue to 
incorporate these changes into 
[CALCITE-5913](https://issues.apache.org/jira/browse/CALCITE-5913).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to