mihaibudiu commented on code in PR #4570:
URL: https://github.com/apache/calcite/pull/4570#discussion_r2412231822
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -2631,6 +2632,8 @@ private SqlNode registerFrom(
extendList,
forceNullable,
true);
+ scopes.put(node, usingScope);
Review Comment:
A comment explaining why this is the right thing to do would help
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -2508,6 +2508,15 @@ protected void convertFrom(
convertCollectionTable(bb, call2);
return;
+ case LATERAL:
+ call = (SqlCall) from;
+
+ // Dig out real call;.
Review Comment:
This comment is not very precise, and the punctuation is weird too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
