bchapuis commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r2422749674
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactory.java:
##########
@@ -65,6 +65,15 @@ public interface RelDataTypeFactory {
*/
RelDataType createJavaType(Class clazz);
+ /**
+ * Creates a type that corresponds to a Java class, with a given family.
+ *
+ * @param clazz the Java class used to define the type
+ * @param family The family of the type, or null to infer
+ * @return canonical Java type descriptor
+ */
+ RelDataType createJavaType(Class clazz, @Nullable RelDataTypeFamily family);
Review Comment:
Maybe I missundersood the originial comment. However, since my PR introduced
a new createJavaType method with two arguments, we wanted to keep the existing
single-argument createJavaType method to avoid breaking consumers.
If I recall correctly, my fix (on 30.07.2025) involved adding a default
implementation for the single-argument version, as shown below:
```java
default RelDataType createJavaType(Class clazz) {
return createJavaType(clazz, null);
}
RelDataType createJavaType(Class clazz, @Nullable RelDataTypeFamily
family);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
