rubenada commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r2422692135
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactory.java:
##########
@@ -65,6 +65,15 @@ public interface RelDataTypeFactory {
*/
RelDataType createJavaType(Class clazz);
+ /**
+ * Creates a type that corresponds to a Java class, with a given family.
+ *
+ * @param clazz the Java class used to define the type
+ * @param family The family of the type, or null to infer
+ * @return canonical Java type descriptor
+ */
+ RelDataType createJavaType(Class clazz, @Nullable RelDataTypeFamily family);
Review Comment:
@bchapuis I cannot see the default implementation suggested by @zabetak to
avoid breaking consumers.
IIANM the proposal to maintain compatibility was:
```
RelDataType createJavaType(Class clazz);
default RelDataType createJavaType(Class clazz, @Nullable RelDataTypeFamily
family) {
return createJavaType(clazz);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
