strongduanmu commented on code in PR #4553:
URL: https://github.com/apache/calcite/pull/4553#discussion_r2437971948
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -19755,7 +19740,7 @@ LogicalProject(A=[$0], Y=[$1])
LogicalJoin(condition=[AND(=($0, $2), =($1, $3))], joinType=[inner])
LogicalValues(tuples=[[{ 1, 2 }, { 3, null }, { 7369, null }, { 7499, 30
}, { null, 20 }, { null, 5 }]])
LogicalAggregate(group=[{0, 1}])
- LogicalValues(tuples=[[{ 1, 2 }, { 3, null }, { 7369, null }, { null, 20
}, { null, 5 }, { 7499, 30 }]])
+ LogicalValues(tuples=[[{ 1, 2 }, { null, 20 }, { 3, null }, { 7369, null
}, { 7499, 30 }, { null, 5 }]])
Review Comment:
Yes, it's neccessay. This order is generated by the `UnionToValuesRule` rule
based on planBefore. For details, see the corresponding relationship in the
following figure.
<img width="1832" height="1026" alt="image"
src="https://github.com/user-attachments/assets/4984f275-3051-4cf2-a249-0e45ddeb7c15";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
