strongduanmu commented on code in PR #4553:
URL: https://github.com/apache/calcite/pull/4553#discussion_r2430912505
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -19698,16 +19698,7 @@ LogicalProject(A=[$0], Y=[$1])
LogicalProject(EXPR$0=[$0], EXPR$1=[$1])
LogicalValues(tuples=[[{ 1, 2 }, { 3, null }, { 7369, null }, { 7499, 30
}, { null, 20 }, { null, 5 }]])
LogicalAggregate(group=[{0, 1}])
- LogicalUnion(all=[true])
- LogicalProject(EXPR$0=[3], EXPR$1=[null:INTEGER])
- LogicalValues(tuples=[[{ 0 }]])
- LogicalProject(EXPR$0=[7369], EXPR$1=[null:INTEGER])
- LogicalValues(tuples=[[{ 0 }]])
- LogicalProject(EXPR$0=[null:INTEGER], EXPR$1=[20])
- LogicalValues(tuples=[[{ 0 }]])
- LogicalProject(EXPR$0=[null:INTEGER], EXPR$1=[5])
- LogicalValues(tuples=[[{ 0 }]])
- LogicalValues(tuples=[[{ 1, 2 }, { 7499, 30 }]])
+ LogicalValues(tuples=[[{ 1, 2 }, { 3, null }, { 7369, null }, { 7499, 30
}, { null, 20 }, { null, 5 }]])
Review Comment:
Yes, this change is due to the additional validation logic for ROW
expressions, which allows the type of the item in each ROW expression to be
inferred, avoiding additional type conversions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
