silundong commented on code in PR #4619:
URL: https://github.com/apache/calcite/pull/4619#discussion_r2502351928
##########
core/src/main/java/org/apache/calcite/rel/core/Correlate.java:
##########
@@ -77,6 +78,7 @@ public abstract class Correlate extends BiRel implements
Hintable {
protected final ImmutableBitSet requiredColumns;
protected final JoinRelType joinType;
protected final ImmutableList<RelHint> hints;
+ protected final RexNode condition;
Review Comment:
This is also my concern. When removing SOME/IN subqueries, the condition
need to be retained in Mark type Correlate (it cannot be pulled up or pushed
down). So I temporarily added the condition to Correlate and implemented some
constraints to ensure the original behavior isn't affected. Should I create a
new operator?
##########
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##########
@@ -945,4 +945,13 @@ private CoreRules() {}
* into equivalent {@link Union} ALL of GROUP BY operations. */
public static final AggregateGroupingSetsToUnionRule
AGGREGATE_GROUPING_SETS_TO_UNION =
AggregateGroupingSetsToUnionRule.Config.DEFAULT.toRule();
+
+ public static final SubQueryRemoveRule
FILTER_SUBQUERY_REMOVE_ENABLE_MAKE_JOIN =
Review Comment:
Sorry, it should be MARK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
