dssysolyatin commented on code in PR #4625:
URL: https://github.com/apache/calcite/pull/4625#discussion_r2504555685
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/NullPolicy.java:
##########
@@ -32,8 +32,6 @@ public enum NullPolicy {
STRICT,
/** Returns null if one of the arguments is null, and possibly other times.
*/
SEMI_STRICT,
- /** If any of the arguments are null, return null. */
- ANY,
Review Comment:
Well, for me, it’s also fine because I use Calcite as a direct dependency
and don’t care about binary compatibility. But for some reason, we keep the
@Deprecated constructors, as it’s also a straightforward change. Probably
because some users may have Calcite as a transitive dependency and would like
to upgrade Calcite before the libraries that use it are upgraded. I also
remember Julian mentioning something about replacing JARs on the fly or
something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
