thomasrebele commented on code in PR #4616:
URL: https://github.com/apache/calcite/pull/4616#discussion_r2533424726
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -1231,7 +1230,7 @@ private RexNode simplifyIs(RexCall call, RexUnknownAs
unknownAs) {
return RexUtil.composeDisjunction(rexBuilder, operands, false);
case AS_IS:
default:
- return null;
+ return rexBuilder.makeCall(SqlStdOperatorTable.IS_NULL, a);
Review Comment:
I've reduced the scope of the PR as much as possible. It is a bit
unfortunate, as the proposed changes improved the handling of certain
expressions (e.g., simplifying the arguments at least, instead of just doing
nothing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
