zabetak commented on code in PR #4616:
URL: https://github.com/apache/calcite/pull/4616#discussion_r2534010904
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -1231,7 +1230,7 @@ private RexNode simplifyIs(RexCall call, RexUnknownAs
unknownAs) {
return RexUtil.composeDisjunction(rexBuilder, operands, false);
case AS_IS:
default:
- return null;
+ return rexBuilder.makeCall(SqlStdOperatorTable.IS_NULL, a);
Review Comment:
I logged https://issues.apache.org/jira/browse/CALCITE-7294 for tracking
this further also I am not sure to what extend we are missing simplifications.
We can continue the discussion there and refine the scope if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
