asolimando commented on code in PR #4674:
URL: https://github.com/apache/calcite/pull/4674#discussion_r2607586240
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -11025,6 +11025,35 @@ private void checkLiteral2(String expression, String
expected) {
.ok(expected);
}
+ /** Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7319";>[CALCITE-7319]
+ * FILTER_INTO_JOIN rule loses correlation variable context in
HepPlanner</a>. */
+ @Test void testFilterIntoJoinMissingVariableCor() {
Review Comment:
At first I was considering adding tests for LEFT/RIGHT/FULL OUTER joins, but
we bail out pretty early and in a rather generic way which is not
join-dependant. It seems conservative but safe to me. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
