mihaibudiu commented on code in PR #4674:
URL: https://github.com/apache/calcite/pull/4674#discussion_r2608635633


##########
core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java:
##########
@@ -84,6 +84,11 @@ protected void perform(RelOptRuleCall call, @Nullable Filter 
filter,
       return;
     }
 
+    if (filter != null

Review Comment:
   This change is somewhat radical, since it will prevent pushing any 
predicates of the filter.
   I wonder if the rule could be changed so that predicates with correlated 
variables cannot be pushed, while the others still can.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to