mihaibudiu commented on code in PR #4683:
URL: https://github.com/apache/calcite/pull/4683#discussion_r2615993042
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -813,6 +813,9 @@ ExInst<CalciteException>
illegalArgumentForTableFunctionCall(String a0,
@BaseMessage("SELECT * EXCLUDE list contains unknown column(s): {0}")
ExInst<SqlValidatorException>
selectStarExcludeListContainsUnknownColumns(String columns);
+ @BaseMessage("SELECT * EXCLUDE list cannot exclude all columns")
Review Comment:
are you missing the corresponding property?
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -789,6 +792,8 @@ private boolean expandStar(List<SqlNode> selectItems,
Set<String> aliases,
throw newValidationError(prefixId, RESOURCE.starRequiresRecordType());
}
throwIfUnknownExcludeColumns(excludeIdentifiers, excludeMatched);
+ throwIfExcludeLeavesNoColumns(excludeIdentifiers, fieldsBeforeStar,
Review Comment:
I would call this "excludeEliminatesAllColumns"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
