xiedeyantu commented on code in PR #4683:
URL: https://github.com/apache/calcite/pull/4683#discussion_r2616001461
##########
core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties:
##########
@@ -268,6 +268,7 @@ SelectMissingFrom=SELECT must have a FROM clause
SelectStarRequiresFrom=SELECT * requires a FROM clause
SelectExcludeRequiresStar=EXCLUDE clause must follow a STAR expression
SelectStarExcludeListContainsUnknownColumns=SELECT * EXCLUDE list contains
unknown column(s): {0}
+SelectStarExcludeCannotExcludeAllColumns=SELECT * EXCLUDE list cannot exclude
all columns
Review Comment:
I think merging either one first is fine, but the other one needs a rebase.
Given the questions @julianhyde raised in that Jira post, perhaps we can make
this PR ready first, merge this one, and then decide how to handle the other PR
after he has reviewed my response. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
