mihaibudiu commented on code in PR #4699:
URL: https://github.com/apache/calcite/pull/4699#discussion_r2636339232
##########
linq4j/src/main/java/org/apache/calcite/linq4j/function/Functions.java:
##########
@@ -623,10 +620,37 @@ public static int compareLists(List<?> b0, List<?> b1) {
return Integer.compare(b0.size(), b1.size());
}
+ /**
+ * Compares two maps.
+ *
+ * <p>Since maps in Calcite are implemented using {@link
java.util.LinkedHashMap},
Review Comment:
not crazy about this. Is the order of insertion of elements in a map
deterministic? Probably not in general, e.g., if you use an aggregate to build
the map.
In our implementation the maps are actually sorted by key. What do other
system say about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
