xiedeyantu commented on code in PR #4699:
URL: https://github.com/apache/calcite/pull/4699#discussion_r2636579446
##########
linq4j/src/main/java/org/apache/calcite/linq4j/function/Functions.java:
##########
@@ -623,10 +620,37 @@ public static int compareLists(List<?> b0, List<?> b1) {
return Integer.compare(b0.size(), b1.size());
}
+ /**
+ * Compares two maps.
+ *
+ * <p>Since maps in Calcite are implemented using {@link
java.util.LinkedHashMap},
Review Comment:
My understanding is that a LinkedHashMap can maintain the insertion order,
allowing for comparisons based on that sequence. Initially, I sorted the data
before comparing, but I found that this approach was inconsistent with DuckDB's
behavior. The main issue is that I couldn’t find another database to compare
results with. Honestly, I don’t have a strong preference for whether sorting
should be done before comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
