mihaibudiu commented on code in PR #4704:
URL: https://github.com/apache/calcite/pull/4704#discussion_r2641412508


##########
core/src/test/java/org/apache/calcite/test/CoreQuidemTest.java:
##########
@@ -80,6 +80,14 @@ public static void main(String[] args) throws Exception {
               .with(CalciteConnectionProperty.FUN, SqlLibrary.CALCITE.fun)
               .with(CalciteAssert.Config.SCOTT)
               .connect();
+        case "scott-top-down":

Review Comment:
   This will require doubling the number of "connections" to test everything.
   I was thinking to do this by creating a single extra test file that inherits 
CoreQuidemTests and which sets the new algorithm for all test files and just 
runs all of them.
   (The ones which output plans will fail, though, so something has to be done 
about that.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to