xiedeyantu commented on code in PR #4704:
URL: https://github.com/apache/calcite/pull/4704#discussion_r2641478533
##########
core/src/test/java/org/apache/calcite/test/CoreQuidemTest.java:
##########
@@ -80,6 +80,14 @@ public static void main(String[] args) throws Exception {
.with(CalciteConnectionProperty.FUN, SqlLibrary.CALCITE.fun)
.with(CalciteAssert.Config.SCOTT)
.connect();
+ case "scott-top-down":
Review Comment:
That's a good idea. However, I'm worried that this work will take a long
time, and it might be better to migrate the .iq files one by one, or even just
a portion of the content within a file? Wouldn't using the same `.iq` file be
quite messy? While we can use `!if (enable_new_decorrelator) { ... }` to mark
it, wouldn't that be too cluttered? Alternatively, could we have the new
QuidmCoreTests initially only involve the newly added `decorrelate.iq` file,
and then gradually add the `!if` statements to the existing files to maintain
two different logics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
