lincoln-lil commented on PR #4739: URL: https://github.com/apache/calcite/pull/4739#issuecomment-3738093913
> Although the current change does not break any existing tests, it reveals a potential impact at https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/rel/logical/LogicalWindow.java#L252 . This change breaks the assumption in LogicalWindow that OVER window aggregate calls use column names with the '$' prefix, this should be updated accordingly. The incorrect intermediate rowtype of the logicWindow: <img width="4158" height="1214" alt="image" src="https://github.com/user-attachments/assets/96ad7bbc-4b30-4adf-a4e7-327e8c72e407"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
