mihaibudiu commented on code in PR #4739:
URL: https://github.com/apache/calcite/pull/4739#discussion_r2684080221
##########
core/src/main/java/org/apache/calcite/rel/rules/CalcRelSplitter.java:
##########
@@ -627,18 +627,39 @@ private RexProgram createProgramForLevel(
outputRowType);
}
- private String deriveFieldName(RexNode expr, int ordinal) {
+ private String deriveFieldName(RexNode expr, int exprIndex, int ordinal) {
Review Comment:
Could you document the purpose of the two indexes using JavaDoc?
It's not obvious for a reader what they represent.
##########
core/src/main/java/org/apache/calcite/rel/rules/CalcRelSplitter.java:
##########
@@ -627,18 +627,39 @@ private RexProgram createProgramForLevel(
outputRowType);
}
- private String deriveFieldName(RexNode expr, int ordinal) {
+ private String deriveFieldName(RexNode expr, int exprIndex, int ordinal) {
Review Comment:
I think the return type must be annotated with `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
