zhuwenzhuang commented on code in PR #4761:
URL: https://github.com/apache/calcite/pull/4761#discussion_r2720944351
##########
core/src/main/java/org/apache/calcite/jdbc/JavaRecordType.java:
##########
@@ -41,14 +39,15 @@ public JavaRecordType(List<RelDataTypeField> fields, Class
clazz) {
this.clazz = requireNonNull(clazz, "clazz");
}
- @Override public boolean equals(@Nullable Object obj) {
+ @Override public boolean deepEquals(Object obj) {
Review Comment:
If we allow user to implement equals/hashCode for nested type, cache for
hashCode and pointer compare for deepEquals will not work for them.
This situation is similiar to
https://issues.apache.org/jira/browse/CALCITE-3786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
