xiedeyantu commented on code in PR #4761: URL: https://github.com/apache/calcite/pull/4761#discussion_r2723377648
########## core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java: ########## @@ -60,7 +59,7 @@ public abstract class RelDataTypeImpl //~ Instance fields -------------------------------------------------------- protected final @Nullable List<RelDataTypeField> fieldList; - protected @Nullable String digest; + protected RelDataTypeDigest digest; Review Comment: My suggestion is that some protected/public variables and methods must still be guaranteed to work properly. For example, this "String digest" might eventually call "toString" from "RelDataTypeDigest" to get the value? Because these variables are exposed to users, and someone might currently be using them, we need to provide a compatibility fix. If you think reassigning the original variable would go against your design intention (e.g., it might increase memory usage instead of reducing it), then you need to declare that this is a breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
