xiedeyantu commented on code in PR #4785:
URL: https://github.com/apache/calcite/pull/4785#discussion_r2766243725
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoinRule.java:
##########
@@ -60,6 +61,13 @@ protected EnumerableMergeJoinRule(Config config) {
@Override public @Nullable RelNode convert(RelNode rel) {
Join join = (Join) rel;
+ // MergeJoin cannot handle IS NOT DISTINCT FROM because it stops at NULL
values
Review Comment:
I'd like to keep these two: one explaining the reason, and the other
describing a reasonable approach. However, supporting "IS NOT DISTINCT FROM"
would require modifying Linq4j, which doesn't seem straightforward. So, I'll
add an extra TODO for now. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
