xiedeyantu commented on code in PR #4785:
URL: https://github.com/apache/calcite/pull/4785#discussion_r2766289295
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoinRule.java:
##########
@@ -60,6 +61,13 @@ protected EnumerableMergeJoinRule(Config config) {
@Override public @Nullable RelNode convert(RelNode rel) {
Join join = (Join) rel;
+ // MergeJoin cannot handle IS NOT DISTINCT FROM because it stops at NULL
values
Review Comment:
Is it acceptable to change it to the following format?
```
// TODO: support IS NOT DISTINCT FROM condition as join keys of
MergeJoin.
// MergeJoin cannot handle IS NOT DISTINCT FROM because it stops at
NULL values
// while IS NOT DISTINCT FROM treats NULL = NULL as true.
```
I couldn't find anything similar on Jira, or maybe I'm just not very good at
using Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
