caicancai commented on code in PR #4848:
URL: https://github.com/apache/calcite/pull/4848#discussion_r3006219939
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTranslator.java:
##########
@@ -61,13 +63,24 @@ public static ArrowTranslator create(RexBuilder rexBuilder,
return new ArrowTranslator(rexBuilder, rowType);
}
- List<String> translateMatch(RexNode condition) {
- List<RexNode> disjunctions = RelOptUtil.disjunctions(condition);
- if (disjunctions.size() == 1) {
- return translateAnd(disjunctions.get(0));
- } else {
- throw new UnsupportedOperationException("Unsupported disjunctive
condition " + condition);
+ /** The maximum number of nodes allowed during CNF conversion.
+ * If exceeded, the original expression is returned unchanged. */
Review Comment:
add `testLiteralWithEmptyString`
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java:
##########
@@ -184,6 +178,43 @@ private static RelDataType deduceRowType(Schema schema,
return builder.build();
}
+ /** Parses a single condition into a Gandiva {@link TreeNode}.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
