caicancai commented on code in PR #4848:
URL: https://github.com/apache/calcite/pull/4848#discussion_r3006220697
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowRel.java:
##########
@@ -41,15 +41,15 @@ public interface ArrowRel extends RelNode {
* {@link ArrowRel} nodes into a SQL query. */
class Implementor {
@Nullable List<Integer> selectFields;
- final List<String> whereClause = new ArrayList<>();
+ final List<List<List<String>>> whereClause = new ArrayList<>();
@Nullable RelOptTable table;
@Nullable ArrowTable arrowTable;
/** Adds new predicates.
*
- * @param predicates Predicates
+ * @param predicates Predicates in CNF form (outer list is AND, inner list
is OR)
Review Comment:
Thank you, I have improved the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
