Diveyam-Mishra commented on code in PR #4893:
URL: https://github.com/apache/calcite/pull/4893#discussion_r3193477368
##########
example/csv/src/main/java/org/apache/calcite/adapter/csv/CsvScannableTable.java:
##########
@@ -58,7 +58,7 @@ public class CsvScannableTable extends CsvTable
return new AbstractEnumerable<@Nullable Object[]>() {
@Override public Enumerator<@Nullable Object[]> enumerator() {
return new CsvEnumerator<>(source, cancelFlag, false, null,
- CsvEnumerator.arrayConverter(fieldTypes, fields, false));
+ CsvEnumerator.arrayConverter(fieldTypes, fields, false), ',');
Review Comment:
I can make the necessary changes and revert to the previous approach if
that’s preferred. Otherwise, I’ll wait for confirmation before updating the PR
further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]