zabetak commented on code in PR #4928:
URL: https://github.com/apache/calcite/pull/4928#discussion_r3248489041
##########
core/src/main/java/org/apache/calcite/rel/RelShuttle.java:
##########
@@ -75,5 +84,23 @@ public interface RelShuttle {
RelNode visit(LogicalRepeatUnion logicalRepeatUnion);
+ RelNode visit(Window window);
+
+ RelNode visit(Snapshot snapshot);
+
+ RelNode visit(Collect collect);
+
+ RelNode visit(Sample sample);
+
+ RelNode visit(Uncollect uncollect);
+
+ RelNode visit(Combine combine);
+
+ RelNode visit(ConditionalCorrelate conditionalCorrelate);
+
+ RelNode visit(SortExchange sortExchange);
+
+ RelNode visit(TableSpool tableSpool);
+
Review Comment:
The changes here contradict a bit the Javadoc of this interface and change
significantly its current purpose since the new visit methods are not logical
relational expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
