venkata91 commented on code in PR #4928: URL: https://github.com/apache/calcite/pull/4928#discussion_r3236552922
########## site/_docs/history.md: ########## @@ -68,6 +68,26 @@ The same applies to `SqlBabelCreateTable` and `SqlUnpivot`. * [<a href="https://issues.apache.org/jira/browse/CALCITE-6942";>CALCITE-6942</a>] Rename the method `decorrelateFetchOneSort` to `decorrelateSortWithRowNumber`. +* [<a href="https://issues.apache.org/jira/browse/CALCITE-7511";>CALCITE-7511</a>] +The abstract `TableFunctionScan`, `Window`, and `Snapshot` rel classes now override +`accept(RelShuttle)`, and `RelShuttle` declares new `visit(Window)` and `visit(Snapshot)` +overloads (with default implementations in `RelShuttleImpl` / `RelHomogeneousShuttle`). +Two consumer-facing changes follow: +(1) Callers that implement `RelShuttle` directly must implement the two new methods. +(2) Callers that subclassed `RelShuttleImpl` and routed `Window` / `Snapshot` / +`TableFunctionScan` through `visit(RelNode other)` with `instanceof` checks should +migrate to the type-specific `visit(Window)` / `visit(Snapshot)` / Review Comment: Yes that will be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
