zzwqqq commented on code in PR #4942:
URL: https://github.com/apache/calcite/pull/4942#discussion_r3292904162
##########
core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java:
##########
@@ -160,6 +164,171 @@ protected void check(final Action action) {
});
}
+ @Test void testReduceTimeCastWithMicroseconds() {
+ checkHighPrecision((rexBuilder, executor) -> {
+ final RexNode cast =
+ rexBuilder.makeCast(
+ rexBuilder.getTypeFactory().createSqlType(SqlTypeName.TIME, 6),
+ rexBuilder.makeLiteral("12:34:56.123456"));
+
+ final RexNode reduced = reduce(rexBuilder, executor, cast).get(0);
+
+ assertThat(reduced, instanceOf(RexLiteral.class));
+ assertThat(
+ ((RexLiteral) reduced).getValueAs(TimeString.class).toString(6),
+ equalTo("12:34:56.123456"));
+ });
+ }
+
+ @Test void testReduceTimestampCastWithMicroseconds() {
+ checkHighPrecision((rexBuilder, executor) -> {
+ final RexNode cast =
+ rexBuilder.makeCast(
+ rexBuilder.getTypeFactory().createSqlType(SqlTypeName.TIMESTAMP,
6),
+ rexBuilder.makeLiteral("2020-01-01 12:34:56.123456"));
+
+ final RexNode reduced = reduce(rexBuilder, executor, cast).get(0);
+
+ assertThat(reduced, instanceOf(RexLiteral.class));
+ assertThat(
+ ((RexLiteral) reduced).getValueAs(TimestampString.class).toString(6),
+ equalTo("2020-01-01 12:34:56.123456"));
+ });
+ }
+
+ @Test void testReduceLiteralWithMicroseconds() {
+ checkHighPrecision((rexBuilder, executor) -> {
+ final RexLiteral timeLiteral =
+ rexBuilder.makeTimeLiteral(new TimeString("12:34:56.123456"), 6);
+ final RexLiteral timestampLiteral =
+ rexBuilder.makeTimestampLiteral(
+ new TimestampString("2020-01-01 12:34:56.123456"), 6);
+ final RexNode expression =
+ rexBuilder.makeCall(SqlStdOperatorTable.PLUS,
+ rexBuilder.makeExactLiteral(BigDecimal.TEN),
+ rexBuilder.makeExactLiteral(BigDecimal.ONE));
+
+ final List<RexNode> reducedValues =
+ reduce(rexBuilder, executor, timeLiteral, expression,
timestampLiteral);
+
+ assertThat(reducedValues, hasSize(3));
+ assertThat(
+ ((RexLiteral)
reducedValues.get(0)).getValueAs(TimeString.class).toString(6),
+ equalTo("12:34:56.123456"));
+ assertThat(((RexLiteral) reducedValues.get(1)).getValue2(),
equalTo(11L));
+ assertThat(
+ ((RexLiteral) reducedValues.get(2)).getValueAs(TimestampString.class)
+ .toString(6),
+ equalTo("2020-01-01 12:34:56.123456"));
+ });
+ }
+
+ @Test void testReduceTimeToVarcharWithMicroseconds() {
+ checkHighPrecision((rexBuilder, executor) -> {
+ final RelDataTypeFactory typeFactory = rexBuilder.getTypeFactory();
+ final RexNode castToTime =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.TIME, 6),
+ rexBuilder.makeLiteral("12:34:56.123456"));
+ final RexNode castToVarchar =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.VARCHAR,
30),
+ castToTime);
+
+ final RexNode reduced = reduce(rexBuilder, executor,
castToVarchar).get(0);
+
+ assertThat(reduced, instanceOf(RexLiteral.class));
+ assertThat(((RexLiteral) reduced).getValueAs(String.class),
+ equalTo("12:34:56.123456"));
+ });
+ }
+
+ @Test void testReduceTimeToVarcharWithMilliseconds() {
+ check((rexBuilder, executor) -> {
+ final RelDataTypeFactory typeFactory = rexBuilder.getTypeFactory();
+ final RexNode castToTime =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.TIME, 3),
+ rexBuilder.makeLiteral("12:34:56.987654"));
+ final RexNode castToVarchar =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.VARCHAR,
30),
+ castToTime);
+
+ final RexNode reduced = reduce(rexBuilder, executor,
castToVarchar).get(0);
+
+ assertThat(reduced, instanceOf(RexLiteral.class));
+ assertThat(((RexLiteral) reduced).getValueAs(String.class),
+ equalTo("12:34:56.987"));
+ });
+ }
+
+ @Test void testReduceTimeToVarcharWithZeroMilliseconds() {
+ check((rexBuilder, executor) -> {
+ final RelDataTypeFactory typeFactory = rexBuilder.getTypeFactory();
+ final RexNode castToTime =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.TIME, 3),
+ rexBuilder.makeLiteral("12:34:56.000456"));
+ final RexNode castToVarchar =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.VARCHAR,
30),
+ castToTime);
+
+ final RexNode reduced = reduce(rexBuilder, executor,
castToVarchar).get(0);
+
+ assertThat(reduced, instanceOf(RexLiteral.class));
+ assertThat(((RexLiteral) reduced).getValueAs(String.class),
+ equalTo("12:34:56.000"));
+ });
+ }
+
+ @Test void testReduceTimestampToVarcharWithMicroseconds() {
+ checkHighPrecision((rexBuilder, executor) -> {
+ final RelDataTypeFactory typeFactory = rexBuilder.getTypeFactory();
+ final RexNode castToTimestamp =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.TIMESTAMP,
6),
+ rexBuilder.makeLiteral("2020-01-01 12:34:56.000456"));
+ final RexNode castToVarchar =
+ rexBuilder.makeCast(typeFactory.createSqlType(SqlTypeName.VARCHAR,
30),
+ castToTimestamp);
+
+ final RexNode reduced = reduce(rexBuilder, executor,
castToVarchar).get(0);
+
+ assertThat(reduced, instanceOf(RexLiteral.class));
+ assertThat(((RexLiteral) reduced).getValueAs(String.class),
+ equalTo("2020-01-01 12:34:56.000456"));
+ });
+ }
+
+ private static void checkHighPrecision(Action action) {
+ action.check(new RexBuilder(highPrecisionTemporalTypeFactory()),
executor());
+ }
+
+ private static List<RexNode> reduce(RexBuilder rexBuilder,
+ RexExecutorImpl executor, RexNode... nodes) {
+ final List<RexNode> reducedValues = new ArrayList<>();
+ executor.reduce(rexBuilder, ImmutableList.copyOf(nodes), reducedValues);
+ return reducedValues;
+ }
+
+ private static RelDataTypeFactory highPrecisionTemporalTypeFactory() {
+ return new JavaTypeFactoryImpl(
Review Comment:
Expanded these to run through precisions 1..9. I did the same for the
temporal-to-VARCHAR cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
