zzwqqq commented on code in PR #4942:
URL: https://github.com/apache/calcite/pull/4942#discussion_r3292906020
##########
core/src/main/java/org/apache/calcite/rex/RexExecutorImpl.java:
##########
@@ -136,14 +137,32 @@ public static RexExecutable getExecutable(RexBuilder
rexBuilder, List<RexNode> e
@Override public void reduce(RexBuilder rexBuilder, List<RexNode> constExps,
List<RexNode> reducedValues) {
assert reducedValues.isEmpty();
+ final List<RexNode> exps = new ArrayList<>();
Review Comment:
Done. I added a comment explaining that RexLiteral inputs are already
reduced, so reduce keeps them as Rex values instead of round-tripping them
through generated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
