mihaibudiu commented on code in PR #4942:
URL: https://github.com/apache/calcite/pull/4942#discussion_r3299959398
##########
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##########
@@ -958,6 +958,11 @@ public RexNode makeCast(
return temporalLiteral;
}
+ /** Converts a TIME or TIMESTAMP literal to a character literal.
+ *
+ * <p>Returns null if the literal type is not supported, the literal value is
+ * unavailable, or the formatted temporal value does not fit in the target
Review Comment:
Please do not document what the caller does, it's not the job of the callee.
Other callers may be added in the future.
What is "value is unavailable"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
