OldTruckDriver opened a new pull request, #4991: URL: https://github.com/apache/calcite/pull/4991
`SqlFunctions.DateParseFunction.parseTimestamp(fmt, string, timeZone)` used `TimeZone.getTimeZone(String)`, which silently falls back to GMT for unknown zone IDs, so a typo in the time-zone argument of BigQuery-style `PARSE_TIMESTAMP` changed query results instead of raising an error. Following the same approach as CALCITE-7559, the zone is now validated with `ZoneId.of(...)`, which throws for unknown ids. The check runs before the cached `DateFormat` path, so that path no longer sees an unvalidated zone either. Added `SqlFunctionsTest.testParseTimestampRejectsUnknownTimeZone`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
