chrisdennis commented on code in PR #5012:
URL: https://github.com/apache/calcite/pull/5012#discussion_r3399996833
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -9693,7 +9693,12 @@ private static Consumer<List<? extends Throwable>>
checkWarnings(
final String sql1 = "select "
+ "/*+ properties(^k1^=123, k2='v2'), no_hash_join() */ "
+ "empno, ename, deptno from emps";
- sql(sql1).fails("(?s).*Encountered \"k1 = 123\" at .*");
+ // Allow numeric literal k/v values.
+ final String expected1 = "SELECT\n"
Review Comment:
That would make sense, but I'll add them to `SqlHintsConverterTest` rather
than here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
