mihaibudiu commented on code in PR #5012:
URL: https://github.com/apache/calcite/pull/5012#discussion_r3408670954
##########
core/src/main/java/org/apache/calcite/sql/SqlHint.java:
##########
@@ -197,18 +197,19 @@ public enum HintOptionFormat implements Symbolizable {
* The hint options are list of key-value pairs.
* For each pair,
* the key is a simple identifier or string literal,
- * the value is a string literal.
+ * the value is a string or numeric literal.
*/
KV_LIST
}
//~ Tools ------------------------------------------------------------------
- private static String getOptionAsString(SqlNode node) {
+ private String getOptionAsString(SqlNode node) {
Review Comment:
why remove the static?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
