mihaibudiu commented on code in PR #5007: URL: https://github.com/apache/calcite/pull/5007#discussion_r3423080970
########## core/src/main/java/org/apache/calcite/util/ComparableSqlValue.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.util; + +/** + * Value whose SQL comparison semantics differ from its natural ordering. Review Comment: This seems to be defined only for constant values (a concept which includes literals, but also perhaps constructors applied to constant arguments). The term "value" you used is very overloaded - it can be applied to runtime values as well. ########## core/src/main/java/org/apache/calcite/util/SqlValueComparator.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.util; + +import java.util.Comparator; + +/** Compares values using SQL value semantics. */ +public final class SqlValueComparator implements Comparator<Comparable> { + /** Singleton instance. */ + public static final SqlValueComparator INSTANCE = new SqlValueComparator(); + + private SqlValueComparator() { + } + + @SuppressWarnings({"rawtypes", "unchecked"}) + @Override public int compare(Comparable v0, Comparable v1) { + if (hasCustomSqlValueComparison(v0, v1)) { + return ((ComparableSqlValue) v0).compareSqlValueTo(v1); + } + return v0.compareTo(v1); + } + + /** Returns whether two values should use custom SQL-value comparison. */ + public boolean hasCustomSqlValueComparison(Comparable v0, Comparable v1) { Review Comment: Is the two-argument version of this function really necessary? Is there a case where the one-argument and the two-argument would return different results for the same first argument? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
