zzwqqq commented on code in PR #5041:
URL: https://github.com/apache/calcite/pull/5041#discussion_r3459721726
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -5972,7 +5972,7 @@ private void checkEmptyJoin(RelOptFixture f) {
@Test void testReduceCastsNullable() {
HepProgram program = new HepProgramBuilder()
- // Simulate the way INSERT will insert casts to the target types
+ // Simulate the way INSERT can insert casts to the target types.
Review Comment:
I changed it because `CoerceInputsRule` may now decide not to add a cast. I
can revert this comment if you think it is better to avoid the unrelated diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
