zzwqqq commented on code in PR #5041:
URL: https://github.com/apache/calcite/pull/5041#discussion_r3472309612


##########
server/src/test/resources/sql/materialized_view.iq:
##########
@@ -19,7 +19,7 @@
 !set outputformat mysql
 
 # Create a source table
-create table dept (deptno int not null, name varchar(10));
+create table dept (deptno int not null, name varchar(20));

Review Comment:
   With either `varchar(10)` or `varchar(20)`, the new output is `Engineering`, 
not `Engineerin`, because the implicit narrowing cast is no longer added.
   
   I widened the column because I wanted to avoid implying that over-length 
inserts into `varchar(10)` are intended here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to