Diveyam-Mishra opened a new pull request, #5244: URL: https://github.com/apache/calcite/pull/5244
## Jira Link [CALCITE-7765](https://issues.apache.org/jira/browse/CALCITE-7765) Calcite has several tests marked as disabled. These tests were either left disabled after earlier investigations or became outdated because Calcite’s optimizer and metadata calculations have changed over time. This issue focuses on three disabled tests in the core module and re-enables them after updating them to match current behavior. JdbcTest.testCloneGroupBy2 This test was disabled in 2014 with the comment: “The test returns expected results. Not sure why it is disabled.” The test runs a query involving a four-table join and GROUP BY aggregation on FOODMART_CLONE. The query now executes successfully and produces the expected results without any regressions, so the @Disabled annotation can simply be removed. JdbcTest.testCloneGroupBy2Plan This test was disabled because the actual execution plan differed from the expected plan. The query planner has changed since the test was originally written. The current version of Calcite produces a more optimized plan that uses a semi-join (joinType=[semi]) to remove unnecessary columns from the product table. It also folds the filter literal into 1997:SMALLINT. Since testCloneGroupBy2 confirms that the query itself still produces the correct results, the expected plan is updated to match the current optimizer output and the @Disabled annotation is removed. RelMetadataTest.testPercentageOriginalRowsOneFilter This test was originally disabled when it was ported from Eigenbase because the mock catalog tables did not provide row-count information. As a result, getPercentageOriginalRows fell back to the default equality selectivity of 0.15. In Calcite's current test schema, the dept table has a fixed size of 4 rows. Therefore, equality selectivity is calculated as 1.0 / DEPT_SIZE, which is 0.25. The expected value is updated from the obsolete 0.15 to 1.0 / DEPT_SIZE, and the @Disabled annotation is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
