mihaibudiu commented on code in PR #5244:
URL: https://github.com/apache/calcite/pull/5244#discussion_r3941385349
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -1269,21 +1268,24 @@ private void checkResultSetMetaData(Connection
connection, String sql)
}
/** Tests plan for a query with 4 tables, 3 joins. */
- @Disabled("The actual and expected plan differ")
@Test void testCloneGroupBy2Plan() {
CalciteAssert.that()
.with(CalciteAssert.Config.FOODMART_CLONE)
.query(
"explain plan for select \"time_by_day\".\"the_year\" as \"c0\",
\"time_by_day\".\"quarter\" as \"c1\", \"product_class\".\"product_family\" as
\"c2\", sum(\"sales_fact_1997\".\"unit_sales\") as \"m0\" from \"time_by_day\"
as \"time_by_day\", \"sales_fact_1997\" as \"sales_fact_1997\",
\"product_class\" as \"product_class\", \"product\" as \"product\" where
\"sales_fact_1997\".\"time_id\" = \"time_by_day\".\"time_id\" and
\"time_by_day\".\"the_year\" = 1997 and \"sales_fact_1997\".\"product_id\" =
\"product\".\"product_id\" and \"product\".\"product_class_id\" =
\"product_class\".\"product_class_id\" group by \"time_by_day\".\"the_year\",
\"time_by_day\".\"quarter\", \"product_class\".\"product_family\"")
- .returns("PLAN=EnumerableAggregate(group=[{0, 1, 2}], m0=[SUM($3)])\n"
- + " EnumerableCalc(expr#0..37=[{inputs}], c0=[$t9], c1=[$t13],
c2=[$t4], unit_sales=[$t22])\n"
- + " EnumerableHashJoin(condition=[=($23, $0)],
joinType=[inner])\n"
- + " EnumerableTableScan(table=[[foodmart2, product_class]])\n"
- + " EnumerableHashJoin(condition=[=($10, $19)],
joinType=[inner])\n"
- + " EnumerableHashJoin(condition=[=($11, $0)],
joinType=[inner])\n"
- + " EnumerableCalc(expr#0..9=[{inputs}],
expr#10=[CAST($t4):INTEGER], expr#11=[1997], expr#12=[=($t10, $t11)],
proj#0..9=[{exprs}], $condition=[$t12])\n"
+ .returns(
Review Comment:
very hard for a human to tell whether the plan is right.
The plan has the right shape.
I personally prefer such tests to be written as quidem tests, where we can
feed some data and see the output.
But you didn't write it, you are just re-enabling it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
