This is an automated email from the ASF dual-hosted git repository.
mihaibudiu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 194ce54513 [CALCITE-7767] Re-enable disabled tests in RelMetadataTest
with updated selectivity expectations
194ce54513 is described below
commit 194ce5451393d5226112c8597e5e60fd70b64a9f
Author: Diveyam Mishra <[email protected]>
AuthorDate: Tue Sep 8 02:29:19 2026 +0530
[CALCITE-7767] Re-enable disabled tests in RelMetadataTest with updated
selectivity expectations
---
.../test/java/org/apache/calcite/test/RelMetadataTest.java | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
b/core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
index 2b8e557572..a1780aa319 100644
--- a/core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
+++ b/core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
@@ -242,22 +242,20 @@ final RelMetadataFixture sql(String sql) {
.assertPercentageOriginalRows(isAlmost(1.0 / DEPT_SIZE));
}
- @Disabled
@Test void testPercentageOriginalRowsTwoFilters() {
sql("select * from (\n"
+ " select * from dept where name='X')\n"
+ "where deptno = 20")
.assertPercentageOriginalRows(
- isAlmost(DEFAULT_EQUAL_SELECTIVITY_SQUARED));
+ isAlmost(1.0 / DEPT_SIZE));
}
- @Disabled
@Test void testPercentageOriginalRowsRedundantFilter() {
sql("select * from (\n"
+ " select * from dept where deptno=20)\n"
+ "where deptno = 20")
.assertPercentageOriginalRows(
- isAlmost(DEFAULT_EQUAL_SELECTIVITY));
+ isAlmost(1.0 / DEPT_SIZE));
}
@Test void testPercentageOriginalRowsJoin() {
@@ -265,14 +263,13 @@ final RelMetadataFixture sql(String sql) {
.assertPercentageOriginalRows(isAlmost(1.0));
}
- @Disabled
@Test void testPercentageOriginalRowsJoinTwoFilters() {
sql("select * from (\n"
+ " select * from emp where deptno=10) e\n"
+ "inner join (select * from dept where deptno=10) d\n"
+ "on e.deptno=d.deptno")
.assertPercentageOriginalRows(
- isAlmost(DEFAULT_EQUAL_SELECTIVITY_SQUARED));
+ isAlmost(DEFAULT_EQUAL_SELECTIVITY / DEPT_SIZE));
}
@Test void testPercentageOriginalRowsUnionNoFilter() {
@@ -280,16 +277,14 @@ final RelMetadataFixture sql(String sql) {
.assertPercentageOriginalRows(isAlmost(1.0));
}
- @Disabled
@Test void testPercentageOriginalRowsUnionLittleFilter() {
sql("select name from dept where deptno=20"
+ " union all select ename from emp")
.assertPercentageOriginalRows(
- isAlmost(((DEPT_SIZE * DEFAULT_EQUAL_SELECTIVITY) + EMP_SIZE)
+ isAlmost((1.0 + EMP_SIZE)
/ (DEPT_SIZE + EMP_SIZE)));
}
- @Disabled
@Test void testPercentageOriginalRowsUnionBigFilter() {
sql("select name from dept"
+ " union all select ename from emp where deptno=20")