xuzifu666 commented on PR #5246: URL: https://github.com/apache/calcite/pull/5246#issuecomment-5646163632
Apologies @mihaibudiu , I accidentally squashed the previous commit history with the current changes. Here is an overview of the current modifications: RexSimplify.absorb now recognizes symmetric comparison forms during matching. A new helper, equivalentComparison(a, b), treats two comparisons as equal when they differ only in operand order (a = b ≡ b = a, a < b ≡ b > a) — kind must be reversible and operands cross-equal. It replaces the digest-exact components.contains(other) check inside absorb. No expression is ever rewritten; the surviving term keeps its original form. I have actually added tests for RexSimplify; prior to this change, these tests would not pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
