xuzifu666 commented on PR #5246: URL: https://github.com/apache/calcite/pull/5246#issuecomment-5651020634
> If this code is never executed, it means it has very low coverage. IMO the code should been executed and covered, in both senses: 1. absorb runs on every AND/OR simplification, so the new predicate is on the hot path, not a rare branch. 2. the new symmetric-match branch is exercised directly by testSimplifyComparisonSymmetry: the absorption cases fail under the old code and pass with it, proving the branch is reached and load-bearing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
